search

albertogoffi / toradocu

Toradocu - automated generation of test oracles from Javadoc documentation
Other
42 stars 21 forks source link

Address TODOs in JavadocExtractor#createParamTag #210

Closed ariannab closed 6 years ago

ariannab commented 6 years ago

The TODOs suggested to issue a warning in case there is no matching parameter or there are more than one for the param name in the Javadoc. This is what the pull request implements.

However, I wonder if it would be better to throw an exception. If we don't, we have to return null and the final generated specification would be incomplete. Throwing an exception, Toradocu would not produce the specification at all.

albertogoffi commented 6 years ago

The TODOs suggested to issue a warning in case there is no matching parameter or there are more than one for the param name in the Javadoc. This is what the pull request implements.

However, I wonder if it would be better to throw an exception. If we don't, we have to return null and the final generated specification would be incomplete. Throwing an exception, Toradocu would not produce the specification at all.

What's the difference between this change and pull request #209 (that you reviewed some day ago)?

ariannab commented 6 years ago

Right, I was using the last version of Toradocu on master when I encountered errors in this point of the execution and I didn't think about the other pending pull request. We can close this one.