albertopq / jquery_datepicker

Rails 3 plugin that allows you to select dates from a calendar
91 stars 60 forks source link

Incompatible with Rails 4 #38

Open hale opened 11 years ago

hale commented 11 years ago

Rails 4 brings with it changes to FormBuilder. I'm attempting to make it work with Rails 4 - assuming that doing some kind of switch to ensure backwards compatibility with 3.2 could be added afterwards.

The big change seems to be the difference between how new tags are defined, like:

https://github.com/rails/rails/blob/3-2-stable/actionpack/lib/action_view/helpers/form_helper.rb#L689

vs

https://github.com/rails/rails/blob/4-0-stable/actionpack/lib/action_view/helpers/form_helper.rb#L770

The change breaks on this line:

https://github.com/albertopq/jquery_datepicker/blob/master/lib/app/helpers/form_helper.rb#L9

albertopq commented 11 years ago

Great @hale!

Send a pull request and we can work together on that, or just let me know if you need any help.

Thanks!