Open UrsaDK opened 7 years ago
Personally I'm against the idea of styling the ColorColumn
as invisible: a theme should not force an editor feature to be unusable IMO.
I'll try the reverse trick :+1:
I see your point and I totally agree with "a theme should not force an editor feature to be unusable", but in this case I just couldn't find a better solution... though, I didn't try long. ;)
Let me know if there is anything I can do to help.
I did a full rewrite of the package, can you check if this issue is happening still?
Thanks @albertorestifo! I'll give it a go but it might take me a few days.
Search and/or IncSearch highlighting disappears if the highlighted word happens to be on a ColorColumn.
How to recreate
hisIs
(broken IncSearch highlight) then hit Enter (broken Search highlight)My solution
Normally the way colorschemes get around this issue is by setting
gui=reverse cterm=reverse
on both IncSearch and Search highlight groups. However, doing so here results in a pale text on a pale background when the highlighted characters are on the ColorColumn. This makes the text ineligible. It also resets the foreground colour of the text inside the highlight, which isn't ideal...Personally, I decided to fix this issue by taking a clue from GitHub and disabling ColorColumn highlighting all together:
hi clear ColorColumn
. After all, GitHub doesn't support ColorColumn so by not coloring them in the theme stays true to GitHub's visual styling.However, this solution might not be to everyone's taste.