search

albertosantini / node-rio

Integration with Rserve, a TCP/IP server for R framework
https://github.com/albertosantini/node-conpa
MIT License
176 stars 35 forks source link

Some essential updates #27

Closed satyashani closed 9 years ago

satyashani commented 9 years ago

The changes are - Adds ability to parse json returned by 'jsonlint' library. Replaces error strings with 'Error' objects conforming to NodeJs standard. Adds and updates test for the two above.

Let me know if there's a problem.

Thanks

albertosantini commented 9 years ago

Thanks for your contribution.

dev-2.x branch is in the progress and any further development should be submited there.

Firstly, open a new issue or add a comment to the Roadmap 2.x one, explaining your proposal. Then, the PR should pass the tests.

satyashani commented 9 years ago

Thanks for this guidance. I'm slowly getting to know the git community. Will add comments to Roadmap 2.x.

albertosantini commented 9 years ago

Thanks a lot. Please, add there details about ra === 162 and why we need new Error.

In the meanwhile I close this PR.