search

albertosantini / node-rio

Integration with Rserve, a TCP/IP server for R framework
https://github.com/albertosantini/node-conpa
MIT License
176 stars 35 forks source link

Memroy leaks #39

Closed hitosu closed 7 years ago

hitosu commented 7 years ago

Memory leaks in ./lib/crypt.js : there are lots of variables without var, const or let.

yapus commented 7 years ago

mocha output:

 Error: global leaks detected: i, j, b, k, inbit, obit
albertosantini commented 7 years ago

Thanks for the feedback.

As you noticed that source code is a third-party source code. I didn't modify it, because finally it would be harder to stay in sync with the original source.

I disabled the linter, because there are many errors and warnings.

Also rio has been using that code in a node module (and not in the browser): so the variables without any definition (var, const or let) are global in the module.

If you have any contribution to replace it with a better and maintained code, you are welcome.