albertosgz / Wordpress_BigBlueButton_plugin

BigBlueButton plugin for Wordpress https://es.wordpress.org/plugins/bbb-administration-panel/
GNU General Public License v3.0
17 stars 12 forks source link

auto-join room when 'wait for moderator' is active does not work #29

Closed dvision1979 closed 4 years ago

dvision1979 commented 4 years ago

image

I may have hit a bug here or maybe something changed on the BBB API side. There is an update for BBB since a couple of days ago. Please let me know what other information do you need for debug. Thank you.

[EDIT] Further in the console I get repeated errors: json parse error

albertosgz commented 4 years ago

I know someone which happened the same, but I couldn't find the root of the issue. Can you dig into it a little bit more? About the errors 400 and json error, I don't know what is causing it.

dvision1979 commented 4 years ago

I am still digging into it. I will keep you posted.

[EDIT] I created a new virgin wordpress site and installed the module all by itself. The feature is working. So there must be a conflicting module in my installation which breaks this functionality. I am investigating further.

[EDIT] As I promised I am back with the diagnostic and the solution 😀. The failure occurs when there is a logged in user accessing the feature. This is due to a bad condition handling in admin-ajax.php. The BBB-Administration-Panel plugin adds this action: add_action( 'wp_ajax_nopriv_bbbadminpanel_action_display_redirect_script', 'bbbadminpanel_action_display_redirect_script' );

while in admin-ajax.php a status 400 is thrown because the is no action called wp_ajax_bbbadminpanel_action_display_redirect_script:

if ( is_user_logged_in() ) { // If no action is registered, return a Bad Request response. if ( ! has_action( "wpajax{$action}" ) ) { wp_die( '0', 400 ); } /**

My quick fix is to add the missing action with an add_action call:

//Displays the javascript that handles redirecting a user, when the meeting has started //the meetingName is the meetingID add_action( 'wp_ajax_nopriv_bbbadminpanel_action_display_redirect_script', 'bbbadminpanel_action_display_redirect_script' ); add_action( 'wp_ajax_bbbadminpanel_action_display_redirect_script', 'bbbadminpanel_action_display_redirect_script' );

What do you think?

albertosgz commented 4 years ago

To me it looks great!!! Than you so much again!!! Please don't hesitate to make Pull Requests for these fixes.

albertosgz commented 2 years ago

Fixed on version 1.1.21: https://wordpress.org/plugins/bbb-administration-panel/#developers https://github.com/albertosgz/Wordpress_BigBlueButton_plugin/commit/ab2a2cdc3daa083ce4a1313158e5aac79f5cd4bc Thank you so much dear!