search

albertosgz / Wordpress_BigBlueButton_plugin

BigBlueButton plugin for Wordpress https://es.wordpress.org/plugins/bbb-administration-panel/
GNU General Public License v3.0
17 stars 12 forks source link

getMeetingInfoURLWithoutModeratorPwUrl method missing in the BigBlueButtonAPI #33

Closed anton5rov closed 2 years ago

anton5rov commented 3 years ago

Hi, Alberto, Clicking in the row in the "List of Active Meeting Rooms in BBB Server" section in the admin panel doesn't work as expected for me. The text stated: "Click on the row to see the participants list", but I receive an error in the console "500 (Internal Server Error)". I guess it's a bug due to calling to a non-existing method. The function bbbadminpanel_action_get_meeting_info() at row 1586 calls BigBlueButtonAPI::getMeetingInfoURLWithoutModeratorPwUrl($meetingID, $url_val, $salt_val) but such a method is not defined in the BigBlueButtonAPI. image

I think I can add the method myself, but I'm afraid it could be missing again in the next update.

albertosgz commented 3 years ago

Thank you for the review. Can you make a pull request with the change? it would be very helpful for many people.

anton5rov commented 3 years ago

Pull request send from antonp branch. Some comments added in the code, I hope it wouldn't be a problem to remove them before merge if unnecessary.

albertosgz commented 3 years ago

Already merged. I will update the plugin asap!

albertosgz commented 3 years ago

Plugin updated! please, let me know how it goes.

Alberto Sánchez González

El dom, 28 feb 2021 a las 4:30, anton5rov @.***>) escribió:

Pull request send from antonp branch. Some comments added in the code, I hope it wouldn't be a problem to remove them before merge if unnecessary.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/albertosgz/Wordpress_BigBlueButton_plugin/issues/33#issuecomment-787267323, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4QADYSK46J7QK5IAPRXETTBG2E7ANCNFSM4YKDTTHQ .

anton5rov commented 3 years ago

Checked, participants list shows ok now.