search

albertosottile / darkdetect

Detect OS Dark Mode from Python
Other
171 stars 18 forks source link

Doesn't work for Pop!_OS 22.04 LTS x86_64 #19

Closed nsde closed 2 years ago

nsde commented 2 years ago

My neofetch info (excerpt): WM: Mutter WM Theme: Pop Theme: Pop-dark [GTK2/3] Icons: Pop [GTK2/3] Terminal: gnome-terminal

nsde commented 2 years ago

There is no error. But the package thinks I'm using a light mode even though my theme is dark.

albertosottile commented 2 years ago

Hi, thanks for reporting this. Your theme name ends in -dark so, the detection code should work. Could you run the following command

gsettings get org.gnome.desktop.interface gtk-theme

and report here the output? Thanks.

nsde commented 2 years ago

Sure.

(base) lix@on:~$ gsettings get org.gnome.desktop.interface gtk-theme
'Pop-dark'
(base) lix@on:~$
nsde commented 2 years ago

I actually found out that darkdetect has some issues on Visual Studio Code: image

albertosottile commented 2 years ago

Thanks for triaging this. Because we depend on the result of gsettings get org.gnome.desktop.interface gtk-theme for detecting the theme, I guess you would then have to report this issue upstream to either GNOME or VSCode.

Hence, for the moment, I am closing this issue here.