search

albertov / bindings-gdal

Haskell bindings to the GDAL library
BSD 3-Clause "New" or "Revised" License
13 stars 8 forks source link

Remove usage of addCleanup #17

Closed guibou closed 3 years ago

guibou commented 5 years ago

addCleanup is deprecated in conduit 1.3.0 as detailled in https://github.com/albertov/bindings-gdal/issues/14

This commit is preliminary work to add support for conduit 1.3.0.

albertov commented 5 years ago

Awesome, thanks! I've tagged the PR as "not-ready" since I'm not sure you want me to merge it yet, not implying it's not ready. Feel free to remove the label when you want me to merge it. Appveyor failed but it looks like it has been broken for a long time so don't worry about it

guibou commented 5 years ago

Well. For me that's ready, but there is no unit test at all (I still don't understand anything about gdal neither conduit ;) So if you feel good with that, we can merge.

However I'm surprised that the travis check (which passed) does not appears in the list here.