Willing to PR to refactor the library (before contributing new features)

albertqjiang / INT

Official code for paper: INT: An Inequality Benchmark for Evaluating Generalization in Theorem Proving

MIT License

37 stars 5 forks source link

Willing to PR to refactor the library (before contributing new features) #5

Open fzyzcjy opened 1 year ago

fzyzcjy commented 1 year ago

Hi, before PR for features, I want to firstly PR for refactoring. This is because, from the software engineering perspective, clean code is more maintainable and easy to add new features.

If I do the PR, will you merge it (given good quality code etc)? :)

Sample areas that I may work on:

[ ] Adding unit and integration tests
[ ] Code cleanup

Code cleanup example: In the code below, there are 4 items returned, but unpacked to only 3 variables

albertqjiang commented 1 year ago

Ah yes I'll definitely and very happily merge them!

And I agree that the first thing to do would be create good unit tests.