albertsutz / pe

0 stars 0 forks source link

Storage Class Diagram is messy #17

Open albertsutz opened 2 years ago

albertsutz commented 2 years ago

image.png

The storage Class Diagram is very messy (in particular the arrow on top of each others). Authors should put the details into multiple diagrams rather than putting everything in one diagram.

soc-pe-bot commented 2 years ago

Team's Response

We wanted to show the entire overview of the model, allowing comparisons between each of the components in one place easily, as breaking them up into individual diagrams will hinder readability as readers will have to read a sentence of like:

"Here is the class diagram for ModuleList Storage"

"Here is a class diagram for TaskList Storage"

multiple times.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that "splitting up the diagram" into multiple parts might hinder readability as readers have to refer to multiple diagrams to understand everything COMPLETELY. Afterall, it is only one possible suggestion that I have given.

However, that is not the main problem in this issue. The problem is that the diagram is very messy which you can clearly see by the overlapping arrows. I personally think as a reader, that will hinder my readability as I need to spend more time tracing the arrows.

I think that this issue is valid not only because it hinders the readability of a reader, but it is also a cosmetic bug (which can be clearly seen here).