search

alberttheprince / rpemotes-reborn

Community driven FiveM emote menu with human, animal, and prop support.
GNU General Public License v3.0
64 stars 41 forks source link

The Latest Release has a few issues. #32

Closed 7D7-Development closed 2 months ago

7D7-Development commented 2 months ago

Describe the bug The latest release has a few or more missing commas in AnimationList.lua and the version is incorrect in the fxmanifest.

To Reproduce Steps to reproduce the behaviour:

  1. Click on latest release '1.6.3'.
  2. Install '1.6.3' and configure for your server.
  3. Restart resource or server.
  4. See errors.

Expected behaviour The "Latest Release" shouldn't have these kind of issues.

Additional context Can create PR with fixes.

alberttheprince commented 2 months ago

See my comments on your PR. If this was an issue with https://github.com/alberttheprince/rpemotes-reborn/issues/29

It was fixed and 1.6.3 was republished.

alberttheprince commented 2 months ago

The issues should be fixed with the latest version available in 1.6.3, your PR included an extra copy of the animation list as well.

I think you had added some additional emotes from moustachedom, please PR those separately.

7D7-Development commented 2 months ago

Yes that was un-intentional with the extra emotes, it was from a local copy from testing. If you see my multiple pushes and merge, it sort of explains it. I am fairly new to PR.

So, the latest release is still broken. Same issue. Commas missing and the fxmanifest is incorrect.