alberttheprince / rpemotes-reborn

Community driven FiveM emote menu with human, animal, and prop support.
GNU General Public License v3.0
64 stars 41 forks source link

[bug] Emote cancels if you or someone touches you #59

Closed iSentrie closed 3 weeks ago

iSentrie commented 4 weeks ago

To Reproduce Steps to reproduce the behaviour:

  1. e vest or e wank or plenty others (not all)..
  2. Run in to someone, or wait till someone touches you'
  3. Emote cancels

Expected behaviour Emote shouldn't cancel itself if someone walks very closely to you while waiting in line for food, etc, am I right?

iSentrie commented 4 weeks ago

this behavior stopped for some reason, might be issue somewhere else, closing while doing more research on this

iSentrie commented 4 weeks ago

re-appeared again after resource restart, if someone can, please check this out and let me know if the same happens at your server, so i could start debugging this resource, instead of wasting a lot of time 🗡️

alberttheprince commented 3 weeks ago

Could this be something related to the ESX portion of the code? I've read some report about this from before I maintained rpemotes, but could never reproduce it.

Here is with dance5, but I tried with vest and other emotes and didn't have an issue. You're not the only one who experienced this.

This ESX server reported this issue: https://5metrics.dev/server/lj58r4

back in April:

https://forum.cfx.re/t/free-rpemotes-reborn-a-standalone-emote-system-for-fivem/5219460/30?u=noor_nahas

Video:

https://github.com/user-attachments/assets/02a661d1-b86d-4dc1-95b1-0e614a982005

Mathu-lmn commented 3 weeks ago

Hey the code causing issues might be this one https://github.com/Mathu-lmn/rpemotes-reborn/blob/master/client%2FEmote.lua#L1317 I believe there might be an issue and I'll try to test it asap.

iSentrie commented 3 weeks ago

Hey the code causing issues might be this one https://github.com/Mathu-lmn/rpemotes-reborn/blob/master/client%2FEmote.lua#L1317 I believe there might be an issue and I'll try to test it asap.

yup, there is the issue, why do we need this in first place?

Mathu-lmn commented 3 weeks ago

If the player bumps into a ped while holding a prop for example, the animation cancels but the prop stays

iSentrie commented 3 weeks ago

If the player bumps into a ped while holding a prop for example, the animation cancels but the prop stays

It replays animation after getting bumped, so it seems that it just need some delay aka Wait(2000) before replaying animation

iSentrie commented 3 weeks ago

That was the goal I guess

https://github.com/user-attachments/assets/5f98f244-5205-4080-bc87-50a1c5e0d58a

iSentrie commented 3 weeks ago

Doesn't seem to work with Wait() nor without if it gets ragdoll, also loses emote and keeps prop.

https://github.com/user-attachments/assets/c3baac52-3ffd-42ee-9900-3ef8b2c0c1f2

Mathu-lmn commented 3 weeks ago

If the player bumps into a ped while holding a prop for example, the animation cancels but the prop stays

It replays animation after getting bumped, so it seems that it just need some delay aka Wait(2000) before replaying animation

Yeah that was the goal of the code I sent earlier basically, if we got bumped into, replay the animation