search

alberttheprince / rpemotes-reborn

Community driven FiveM emote menu with human, animal, and prop support.
GNU General Public License v3.0
58 stars 38 forks source link

Props got stuck in the air with preview and I got the message of male only because the preview #6

Closed HideMyFace closed 2 months ago

HideMyFace commented 2 months ago

Describe the bug While scrolling the menu, I got some props stuck in the air with preview enabled (props with colision) and also the message of male only even not pressing enter. Another thing is some previews not work.

To Reproduce Steps to reproduce the behaviour:

  1. Enable preview of anims on menu.
  2. Open the menu and scroll down.

Expected behaviour The props disappearing of screen and the message only appearing when pressing enter.

Additional context None.

TayMcKenzieNZ commented 2 months ago

And this is the very reason why you should always thoroughly check things before mindlessly accepting pull request; though I wouldn't expect anything more from someone who clearly isn't a developer and just forks and claims other people's work 😂

Also appears that they haven't bothered to do animal emote previews. Yikes. Broken feature, yet bragging about it publicly. That's not good, Noor.

alberttheprince commented 2 months ago

Describe the bug While scrolling the menu, I got some props stuck in the air with preview enabled (props with colision) and also the message of male only even not pressing enter. Another thing is some previews not work.

To Reproduce Steps to reproduce the behaviour:

  1. Enable preview of anims on menu.
  2. Open the menu and scroll down.

Expected behaviour The props disappearing of screen and the message only appearing when pressing enter.

Additional context None.

Were there any error messages? We'll take a look at this, thanks for the report. Are other players able to see this props or are they client side only? The props are not networked, so at worst they'll just be clutter for the player previewing animations. We'll look at a potential fix for this.

also the message of male only even not pressing enter. Another thing is some previews not work.

Can you point to which ones don't work? If it says male only it's trying to play certain anims/scenarios that can only be played on male peds, so that's why you'd get that error. Since the preview ped is a clone of your ped, it would give you this error and not play if your ped is female.

alberttheprince commented 2 months ago

And this is the very reason why you should always thoroughly check things before mindlessly accepting pull request; though I wouldn't expect anything more from someone who clearly isn't a developer and just forks and claims other people's work 😂

Also appears that they haven't bothered to do animal emote previews. Yikes. Broken feature, yet bragging about it publicly. That's not good, Noor.

Please refrain from non-issue related discussions, as spammy responses detract from troubleshooting and improvement.

iSentrie commented 2 months ago

https://github.com/user-attachments/assets/0095dcd6-8a3a-434e-9f45-6fe1fae193bd

enzo2991 commented 2 months ago

this only affects the client who is previewing, as the prop is not on the network. I'm already looking into how to fix this

iSentrie commented 2 months ago

Haven't looked in to this feature at all, but maybe make an option for a user to toggle it on/off?

HideMyFace commented 2 months ago

Yes, you have on config the option. Also, thanks for explaining that only the player who used the menu can see the stuck props.

iSentrie commented 2 months ago

I meant togglable in game.

alberttheprince commented 2 months ago

Would be a potential move for the future, although I feel it's more appropriate for the preview option to be set by server managers/owners. If someone did a PR with this as a feature, it would be accepted.

iSentrie commented 2 months ago

Fixed for both main and clone ped. #8

https://github.com/user-attachments/assets/81e2c4b1-f3b1-4646-9d37-8ddc0e71b29d

However need more details or showcase for other problems like:

@HideMyFace While scrolling the menu, I got some props stuck in the air with preview enabled

not completely sure what you mean, but maybe my current fix would fix this too

@HideMyFace message of male only even not pressing enter

that can be fixed too, however clone wont show anything and no message will be shown neither (might be confusing why its not working for some, but i agree to disable it)

@HideMyFace some previews not work.

need more details, because currently i think it's related to what i mentioned above, for example animation is only for male.

🆕Also regarding preview toggle (still has some bugs):

https://github.com/user-attachments/assets/ba4d85aa-2b06-41cf-b519-a97443f972f2