Problem in create_zip_from_files function

albertyw / itolapi

Python API for the Interactive Tree of Life (iTOL)

MIT License

35 stars 11 forks source link

Problem in create_zip_from_files function #28

Closed lperepol closed 5 years ago

lperepol commented 5 years ago

In some cases, the zip file is deleted before it is sent because it is created with a default value of delete=True. The user gets a PermissionError:

albertyw commented 5 years ago

Looking at the code, I don't see an issue here and I can't reproduce the bug. Reading a deleted file should return an IOError, not a PermissionError. I made a few refactors that should ensure there aren't any issues with this function.

Reopen this task if you have a traceback or steps for reproduction.