albertz / background-zmq-ipython

Background ZMQ IPython/Jupyter kernel
BSD 2-Clause "Simplified" License
17 stars 4 forks source link

Redirect stdout and stderr to client #3

Closed tinmarino closed 4 years ago

tinmarino commented 4 years ago

Instead of getting them in the old sys.stdout Fix part1 of issue #2 ipy_thread

tinmarino commented 4 years ago

I think, by default, every user want to see his own output. The last implementation is changing the output only of the current thread: 54970642 Note: if someone else is tampering with std streams (ex: an other async kernel), it should work flawless : the new proxy will call his one if not in the current kernel thread.

What do you think of it? If you don't like it, may you tell me the name of the witch parameter ? Something like redirect_stream=False.

albertz commented 4 years ago

Thanks. Squashed and merged.

tinmarino commented 4 years ago

Thank You Albertz, you wrote a pretty good kernel. And were really fast to review my PRs.