search

albertz / background-zmq-ipython

Background ZMQ IPython/Jupyter kernel
BSD 2-Clause "Simplified" License
17 stars 4 forks source link

Write connection file in jupyter dir if present && shorten log output #4

Closed tinmarino closed 4 years ago

tinmarino commented 4 years ago

Fix part2 of #2: The connection file are written in the current directory which could be annoying. If jupyter is present, it can give a default data path. ipy_thread_filename

You can see that the ls (top right) do not show any kernel-*.json and the --existing advice (bottom left) is shortened to the only required pid (proof right). Also, you can see print as no return because it is another PR to follow the Minimum Viable Change philosophy

albertz commented 4 years ago

Sorry, there is a conflict now after I merged the other PR in. Can you rebase? Otherwise I think we can also merge this in now.

tinmarino commented 4 years ago

Sure, give me 5 min. This is the problem of Minimum viable change method (of witch I am not really fan). Are you actually ?

tinmarino commented 4 years ago

Tested and pushed. The only real conflict was the __init__ parameters. But git got trouble because some function were added just close to some changes.

albertz commented 4 years ago

Thanks, merged now. I guess sometimes Git (or diff/patching) could be more clever, like in such a case, although it can be tricky, and sometimes not so straightforward how it actually should resolve.

tinmarino commented 4 years ago

A pleasure (not to say an honor), to have collaborated. Have a nice Sunday.

albertz commented 4 years ago

I have to thank you. :) Btw, I also just pushed a new release to Pypi.