search

albertz / background-zmq-ipython

Background ZMQ IPython/Jupyter kernel
BSD 2-Clause "Simplified" License
17 stars 4 forks source link

Avoid setting environment variables? #5

Closed user202729 closed 2 years ago

user202729 commented 2 years ago

I suggest adding

https://github.com/albertz/background-zmq-ipython/blob/8084b9a2ba16220c7b3e72e08ee1ac84ff336336/kernel.py#L34-L42

def init_environment(self):
    pass

so that IPython doesn't set some environment variables (such as PAGER=cat), that we don't need anyway. (I think? May need more test)

albertz commented 2 years ago

Yes, probably a good idea.

Do you want to make a PR? Or should I do this change?

user202729 commented 2 years ago

You should do the change, then.