search

albertz / music-player-core

Music player core Python module
BSD 2-Clause "Simplified" License
74 stars 22 forks source link

This should fix build issues #16

Closed edisile closed 4 years ago

edisile commented 5 years ago

Had some issues like #14 building on Arch Linux and using Python 3.7, this fixed them

n-peugnet commented 4 years ago

Hi, I'm really interested by this lib, and I just wanted to add that indeed, this branch managed to build using python3.

Is there plans on merging this and release a version that works with python3 ?

n-peugnet commented 4 years ago

Hi again @albertz, sorry to be insistent but I would really like this PR to be merged. I am currently trying to publish my package on PyPi, but as I am currently using a git url in my install_requires it is not letting me upload it. Do you think that you will have some time to review it and that merging it will be enough to release a version for python3 ?

albertz commented 4 years ago

Sorry for the late reply. This looks good from a first glance. I will just merge it in now. (Btw, a bit meta: if anyone of you feel that you want to take responsibility for helping me maintaining this, such as checking other pull requests, doing fixed like these, and maybe more, contact me. I can give you direct push access to the repo. I'm currently too busy to be really active here.)

albertz commented 4 years ago

As a follow up, e.g. check the Travis tests, why they fail currently.

albertz commented 4 years ago

@n-peugnet You are referring to a separate branch, right? Maybe you can create a separate pull request for that?

n-peugnet commented 4 years ago

@n-peugnet You are referring to a separate branch, right? Maybe you can create a separate pull request for that?

Yes I added a commit to fix travis tests on a separated branch. I will do a pr right now