AcoustID fingerprint doesn't seem to work anymore

[albertz]

You can test via python test_acoustid.py. It doesn't find any references anymore.

I did some git bisect to find out where this happened:

az@ip229 ~/P/music-player> git bisect log
# bad: [45d6827c5a780d95496a0f4ce3d544702db601bc] test_ffmpeg_simple.py
git bisect start 'HEAD'
# bad: [45d6827c5a780d95496a0f4ce3d544702db601bc] test_ffmpeg_simple.py
git bisect bad 45d6827c5a780d95496a0f4ce3d544702db601bc
# bad: [e81c640dc3ab5343b17339d4b1f05164e9067e78] portaudio blocking implementation
git bisect bad e81c640dc3ab5343b17339d4b1f05164e9067e78
# bad: [983e7c25b564ba59dc64883dc27daa068afcf439] ffmpeg: portaudio: use paFramesPerBufferUnspecified
git bisect bad 983e7c25b564ba59dc64883dc27daa068afcf439
# good: [2d99aeb38e351315b035dc380ea4174ede09aac5] ffmpeg: player.outSampleFormat
git bisect good 2d99aeb38e351315b035dc380ea4174ede09aac5
# bad: [7c24e0bd561bebec3192288ff5a7ed2aa7424d41] more debug
git bisect bad 7c24e0bd561bebec3192288ff5a7ed2aa7424d41
# bad: [a8b812587f12173606e050382ffbfd1d71e5557a] stupid fix
git bisect bad a8b812587f12173606e050382ffbfd1d71e5557a
# good: [c4677d91ed039f8470d5ab3aa5549d120ff069d9] ffmpeg: gneralize out sampleformat. int16 atm
git bisect good c4677d91ed039f8470d5ab3aa5549d120ff069d9
# bad: [eecadfbad6432cb093f0b9968ff1ac1dbde1d8d3] fixes
git bisect bad eecadfbad6432cb093f0b9968ff1ac1dbde1d8d3
# good: [fc5380d5eaa08f50c599ab076e2ee4f0ad1ad211] ffmpeg: use float32 as out sampleformat
git bisect good fc5380d5eaa08f50c599ab076e2ee4f0ad1ad211

I.e., we have: eecadfbad6432cb093f0b9968ff1ac1dbde1d8d3 is the first bad commit. These are changes in the file ffmpeg_player_decoding.cpp.

[albertz]

In that commit, the out sample format changed from AV_SAMPLE_FMT_S16 to AV_SAMPLE_FMT_FLT. That very likely caused the problem.