search

albertzl / artisan

Automatically exported from code.google.com/p/artisan
GNU General Public License v3.0
0 stars 0 forks source link

Code review request #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:
/svn/branches/TRY-JimG-TC4arduino/trunk/artisan.py

Comments received from previous review request have been addressed.  Added some 
sleep time for thread stability.

TRY branch code has been tested on Linux and Windows.  Seems to be working well 
on both systems.

In SampleThread class, switched from using time.clock() to time.time() to 
determine elapsed time (time.clock() was fine on Windows, but did not work as 
expected on Linux systems).

When reviewing my code changes, please focus on:

Changes:
1) Forces samples to occur at even multiples of user-specified delay
2) Improves initialization code for TC4 arduino device
3) Fixes typos that resulted in not calling __init__ for SampleThread

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by pidk...@gmail.com on 25 Jun 2011 at 7:10

GoogleCodeExporter commented 9 years ago 
Closed this out dated issue. The review was done by R.

Original comment by luther.m...@gmail.com on 12 Aug 2011 at 6:57