albfan / jmeld

A visual diff and merge tool
44 stars 31 forks source link

build with jdk11 #59

Closed turiot closed 2 years ago

turiot commented 5 years ago

Thanks for the maintenance of this wonderful tool, which works on jdk11. Is it possible to add the following dependencies to pom.xml ?

    <dependency>
        <groupId>org.glassfish.jaxb</groupId>
        <artifactId>jaxb-core</artifactId>
        <version>2.3.0</version>
    </dependency>
    <dependency>
        <groupId>org.glassfish.jaxb</groupId>
        <artifactId>jaxb-runtime</artifactId>
        <version>2.3.0</version>
    </dependency>
    <dependency>
        <groupId>javax.xml.bind</groupId>
        <artifactId>jaxb-api</artifactId>
        <version>2.3.0</version>
        <type>jar</type>
    </dependency>
    <dependency>
        <groupId>javax.activation</groupId>
        <artifactId>activation</artifactId>
        <version>1.1.1</version>
        <type>jar</type>
    </dependency>
albfan commented 5 years ago

You need to explain "why" that dependencies should be added.

By now it is a no. I will reopen if you explain why.

turiot commented 5 years ago

Just because the maven project doesn't build without these dependencies.

albfan commented 5 years ago

CI passes: https://travis-ci.org/albfan/jmeld, so is this related to jdk11?

turiot commented 5 years ago

Of course, cf https://stackoverflow.com/questions/43574426/how-to-resolve-java-lang-noclassdeffounderror-javax-xml-bind-jaxbexception-in-j

albfan commented 5 years ago

Please add a profile activated by jdk and add those extra dependencies https://maven.apache.org/guides/introduction/introduction-to-profiles.html

albfan commented 2 years ago

Thanks @turiot I credited you on 7e5df19f4e73e047488b6f7591908b855fdde151 and restore CI