albfan / jmeld

A visual diff and merge tool
44 stars 31 forks source link

Flat Jar #70

Closed thevpc closed 2 years ago

thevpc commented 2 years ago

Thank you for this amazing piece of work. I love Meld and it was my great joy to discover, very recently actually, that you are rewriting it in java. My concern is only about the release package formats. I see you are using assembly plugin "jar-with-dependencies", could you please continue releasing a plain/flat jar (without embedding dependencies) as well and mainly ensure this plain jar is deployed to maven central (version 3.6.0 is already deployed). Indeed, i'm happy to announce that jmeld can be installed simply (as long as you continue to deploy flat jars) using this command (that works like a charm with the 3.6.0):

nuts install org.jmeld:jmeld

and later can be run

nuts jmeld

nuts is actually a new java package manager we are working on (https://github.com/thevpc/nuts) that supports out of the box maven built packages

albfan commented 2 years ago

First, have to mention that I continue work from original project when it was on sourceforge. Original author retakes it on https://github.com/Mrkuip/jmeld, but I have several fixes related to VCS while he mostly migrates to javaFX. I was unable to port back my changes to his repo.

That said, jmeld plain jar is still released. Removing:

diff --git i/pom.xml w/pom.xml
index 1b97d03..a503517 100644
--- i/pom.xml
+++ w/pom.xml
@@ -128,7 +128,6 @@
                 <artifactId>maven-jar-plugin</artifactId>
                 <version>2.6</version>
                 <configuration>
-                    <finalName>jmeld</finalName>
                     <archive>
                         <manifest>
                             <addClasspath>true</addClasspath>

will generate jmeld-3.6.0.jar instead of jmeld.jar

I'm glad you develop such application, but for people getting nuts trying to run a jar with dependencies, I don't think install another app to wrap that will fix it.

What about offine execution?

thevpc commented 2 years ago

Thanks for the reply. However I'm convinced that a package manager is a better solution for deployment than fat jars: