albfan / nerdtree-git-plugin

A plugin of NERDTree showing git status
15 stars 2 forks source link

Hide folders for patterns ending with `/` #11

Closed bagrat closed 8 years ago

bagrat commented 8 years ago

When there are patterns in .gitignore ending with /, matching directories are not hidden in NERDTree. This PR solves that issue by removing the / suffix from the pattern beforehand.

albfan commented 8 years ago

Seems great @n9code , but avoid whitespace change. Is clearly bad indented (and exist trailing spaces, but that is not part of the fix)

@jlipps How is it that you approve this change? I'm new to these code review features and I would like to know more about it.

If you use this fork I suggest to try to PR upstream. We all can collaborate on that

bagrat commented 8 years ago

@albfan do you mean remove the whitespace changes from this PR? I did not touch identation actually, just removed trailing spaces.

albfan commented 8 years ago

@n9code Yes. It would help to PR to upstream only precise changes.

bagrat commented 8 years ago

Created #12 with no whitespace tweaks.