albfernandez
commented
1 year ago Hi
You must close the detector streams before call getDetectedStream to tell the detector de data is end.
Compare to the current main version where close are called in the finally block.
El dom, 19 feb 2023 a las 0:06, Alessio Cuccovillo (< @.***>) escribió:
Hi @albfernandez https://github.com/albfernandez I'm trying to migrate to JUnit 5 and it works for almost all tests that are already present but not for 3 of them. I've forked this repo and created a branch named it junit5. If you can take a look and help me fixing them, they are:
- BasicStreamEncodingDetectionTest#testEUC
- BasicStreamEncodingDetectionTest#testWindows1255
- BasicStreamEncodingDetectionTest#testShiftJis
This is the url of the branch on my forked copy of this repo: https://github.com/acuccovi/juniversalchardet/tree/junit5
— Reply to this email directly, view it on GitHub https://github.com/albfernandez/juniversalchardet/issues/40#issuecomment-1435788214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUTSNGT6VLAK3YETLSX7QTWYFIWJANCNFSM4V34WXKA . You are receiving this because you were mentioned.Message ID: @.***>
acuccovi
Hi @albfernandez I'm trying to migrate to JUnit 5 and it works for almost all tests that are already present but not for 3 of them. I've forked this repo and created a branch named it junit5. If you can take a look and help me fixing them, they are:
This is the url of the branch on my forked copy of this repo: https://github.com/acuccovi/juniversalchardet/tree/junit5