search

albfernandez / richfaces

RichFaces - JSF component framework
GNU Lesser General Public License v2.1
17 stars 8 forks source link

Jakarta upgrade #80

Open MilovdZee opened 8 months ago

MilovdZee commented 8 months ago

I would like to help with the jakarta upgrade of the 4.6.21 branch. But I don't know how to contact you and I do have a question about building the code. Somehow it always fails with docs and the cdk plugin.

https://www.linkedin.com/in/milo-van-der-zee/

albfernandez commented 8 months ago

Hi Thanks for your interest and support. Richafes are three projects and should be migrate in this order:

MilovdZee commented 8 months ago

Thanks. Problematic thing to get started is that mvn clean compile on the richfaces project fails with the docs generation. It complains about the version being at 7 and it only supports 8. I must be doing something wrong but can't think of how. I tried jdk 8, 11, 17 and 21 with no luck

albfernandez commented 8 months ago

I'll investigate it. It works in my computer but it fails in a clean jvm

albfernandez commented 8 months ago

I've manage to fix it for the package goal.

It should work with java 8 and java 11 (not java 17)

JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64/ mvn clean package

corneil commented 5 months ago

I would also like to offer some help. I have had a good experience using OpenRewrite recipes to upgrade projects.

melloware commented 5 months ago

There already is an open rewrite recipe you can try...

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run
    -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASE
    -Drewrite.activeRecipes=org.openrewrite.java.migrate.jakarta.JakartaEE10

That should do MOST of the heavy lifting converting faces-config.xml, javax to jakarta etc.

albfernandez commented 5 months ago

I would also like to offer some help. I have had a good experience using OpenRewrite recipes to upgrade projects.

The main problem migrating this project to jakarta is update all dependent libraries to modern versions (if they exists), so they can work with java 17 and 21

albfernandez commented 5 months ago

I've created #81 to track migration tasks

miguelzapaton commented 1 month ago

Interested folks please check https://github.com/albfernandez/richfaces/issues/81#issuecomment-2441284928 for updates.