search

albingroen / react-cmdk

A fast, accessible, and pretty command palette for React
https://react-cmdk.com
MIT License
1.1k stars 45 forks source link

Add placeholder props to support multi locales #4

Closed cmpsleo closed 2 years ago

albingroen commented 2 years ago

Looks good!

albingroen commented 2 years ago

Seems to be a conflict in the README file. Please try rebasing locally and fixing the conflict 👍🏼

cmpsleo commented 2 years ago

Thanks for fixing the feedback! Feel free to go ahead and merge and I'll update the version and publish it later 👍🏼

I don't have write access to do it, could you give it to me? I think that it's more clear for me to resolve conflicts too because I can visualize the file comparison.

albingroen commented 2 years ago

Thanks for fixing the feedback! Feel free to go ahead and merge and I'll update the version and publish it later 👍🏼

I don't have write access to do it, could you give it to me? I think that it's more clear for me to resolve conflicts too because I can visualize the file comparison.

I can merge it when the conflicts are resolved. I cloned your repo and tried rebasing and fixing the conflicts and it seemed to work, so it should for you too.

cmpsleo commented 2 years ago

I'm so sorry about taking this too long, but It's my first open-source contribution 😬

albingroen commented 2 years ago

I'm so sorry about taking this too long, but It's my first open-source contribution 😬

No worries mate - great job! One last thing, it would be great if you could squash these 3 commits together and remove the prefix (like "feat:").

cmpsleo commented 2 years ago

I'm so sorry about taking this too long, but It's my first open-source contribution 😬

No worries mate - great job! One last thing, it would be great if you could squash these 3 commits together and remove the prefix (like "feat:").

Done :)