search

albinso / Tale

An extension of the Memoria World of Warcraft addon. Includes a log of notable events and continuous location data.
GNU General Public License v3.0
5 stars 2 forks source link

Version information #13

Closed albinso closed 5 years ago

albinso commented 5 years ago

Since the log format might change between versions it would make sense to have some indicator of version number.

albinso commented 5 years ago

Possible solution: version number as mandatory field for each log entry. Would create some issues since current logs do not include this field. (Can be fixed retroactively by the user but that's not optimal.) Parsers could also interpret a missing version number as version 1.0

albinso commented 5 years ago

Possible solution: A separate data structure which keeps track of version. Contains a tuple of the version number and the index LogData was at when the new version was discovered. Could be a chronological log so changing back and forth is possible.

Something like:

VersionInfo = { "1.0": 0, "1.2": 532, "1.3": 1345, "1.2": 1346, -- 1.3 was broken so going back to 1.2 }

albinso commented 5 years ago

Resolved in fa0801f9d8675e65744a27e741b2de3b55999ee1 and shipped with version 1.1.