search

albo1337 / flutter_full_pdf_viewer

A fully functional on both platforms pdf viewer.
MIT License
165 stars 89 forks source link

iOS Side Should Be Using WkWebview #43

Closed inkrh closed 5 years ago

inkrh commented 5 years ago

In the iOS 12 SDK, UIWebView has been officially deprecated in favor of WKWebView, Apple first advised against using UIWebView in iOS 8 - https://developer.apple.com/documentation/webkit/wkwebview?language=objc.

Flutter Full PDF Viewer currently still uses UIWebView:

https://github.com/albo1337/flutter_full_pdf_viewer/blob/master/ios/Classes/FlutterFullPdfViewerPlugin.m

jeroentrappers commented 5 years ago

Yes, I got this as well while submitting to the app store.

Your delivery was successful, but you may wish to correct the following issues in your next delivery:

ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs . See https://developer.apple.com/documentation/uikit/uiwebview for more information.

jeroentrappers commented 5 years ago

https://github.com/albo1337/flutter_full_pdf_viewer/pull/44

albo1337 commented 5 years ago

Merged it. Will publish new version soon. Stay tuned. @jeroentrappers did you test it? I have no macbook with me, would be great to know if this is 100% working.

Greetings Albo

albo1337 commented 5 years ago

Updated everytihing. Version 1.0.5 is the newest version now

jeroentrappers commented 5 years ago

Thank you for the quick response!

cetorres commented 5 years ago

@albo1337 I just tried the new version 1.0.5 on iOS and it's working only on the Simulator. But not on the device. I tested on iPhone X and iPhone 6 (iOS 12.4.1). Doesn't show the PDF. What do you think it can be? Thank you.

jeroentrappers commented 5 years ago

I'm looking into it, if you have any ideas, pleas share ;-)

jeroentrappers commented 5 years ago

Fix in most recent pull request.

albo1337 commented 5 years ago

I will publish the new version later guys. Are you 100% sure that it works now jeroen?

jeroentrappers commented 5 years ago

I've just tested it on my test-device. It works. However to be sure, it should be tested on multiple devices.

to test you can simply put this in your pubspec.yaml

flutter_full_pdf_viewer:
    git:
      url: git://github.com/jeroentrappers/flutter_full_pdf_viewer
lcossu commented 5 years ago

just tested on my device, it works well. Thank you for the fix.

albo1337 commented 5 years ago

Allrighr i will merge the request and publish a now version today evening. Thank you a lot Jeroen!

cetorres commented 5 years ago

@jeroentrappers @KingLudwig94 @albo1337 Thank you, guys for your fast response and fix! You're the best! 🥇

albo1337 commented 5 years ago

new version 1.0.6 is out now. Please test again and give me feedback guys. If its working, I'll close this ticket. Thank you a lot for all your help

inkrh commented 5 years ago

Thanks @albo1337