search

albrow / jobs

A persistent and flexible background jobs library for go.
MIT License
499 stars 47 forks source link

Adds a check for an empty response to FindById()'s scanJob #19

Closed epelc closed 9 years ago

epelc commented 9 years ago

Fixes #18

Note this doesn't seem to fix it for all transactions but it works for scanJob. Feel free to close if you want to fix it at a higher level.

epelc commented 9 years ago

@albrow This should be good now. It's also passing the tests. I switched my error to ErrJobNotFound which is just an exported var. So users can easily check it like you said.

albrow commented 9 years ago

@epelc thanks for this. I would like to include the job id in the error message. Could you add that?

As described in CONTRIBUTING.md jobs uses a specific branching model and pull requests should request to be merged into develop, not master. Would you mind closing this and submitting a new PR to merge into develop?