search

albzan / eclipse-nvda

NVDA Addon for the Eclipse IDE
GNU General Public License v2.0
10 stars 6 forks source link

Fix dbeaver autocomplete on Windows 11 #15

Closed thgcode closed 7 months ago

thgcode commented 7 months ago

fixes #14 . This PR is a backport of the PR at https://github.com/nvaccess/nvda/pull/16417 , but for older versions of NVDA and accounting for the legacy mode of the addon. With this PR, Users that cannot upgrade to a newer version of NVDA can use autocomplete on Windows 11.

albzan commented 7 months ago

Hi Thiago, Thank you for your PR. I integrated it and I released a new version of the addon which also adds the compatibility flag for 2024.1. Currently I'm not developing in Java, so I don't use Eclipse anymore, for now. So, if you're using this add-on and you'd like to maintain it, I'll be glad to support you in this since I have no possibility to test it against latest Eclipse and/or NVDA versions. Cheers, Alberto

albzan commented 7 months ago

https://github.com/nvaccess/addon-datastore/issues/3295

thgcode commented 7 months ago

Hello Alberto,

Don't worry, I performed various tests both on the latest version of NVDA and the previous version before submitting the PR on your repo and NVDA's repository, both on Eclipse and Dbeaver to make sure it didn't break the functions that were already present.

Sorry, for me would be also complicated to maintain the entire addon, because I also use Eclipse and Dbeaver occasionally, at work the team uses IntelliJ for coding in Java. But I'm watching the repository, if someone finds an error or a edge case with the code I provided, I will create a PR to fix fix it as soon as possible.

Thank you!