search

alcadica / develop

A simple tool to help elementary OS developers to develop their own apps and widgets.
https://github.com/alcadica/develop
GNU General Public License v3.0
40 stars 7 forks source link

Single Page Application #38

Open alonfnt opened 4 years ago

alonfnt commented 4 years ago

I believe that the guidelines say that a single page application shouldn't have a visible header. However this is not always applied.

I think if a single page switch is added to the new app configuration single_page_application

it would help create more consistent apps. The final look would be single_page_exemple

and in order to achieve this, we only need to replace this block of code in the activate method in Application.vala 

window.title = "Single Page Application";
window.set_default_size (900, 640);
window.add (main);
window.show_all ();

for 

window.set_default_size (900, 640);

var titlebar = new Gtk.HeaderBar ();
titlebar.title = "Single Page Application";
titlebar.show_close_button = true;
titlebar.has_subtitle = false;
var titlebar_style_context = titlebar.get_style_context ();
titlebar_style_context.add_class (Gtk.STYLE_CLASS_FLAT);

window.add (main);
window.set_titlebar (titlebar);

so developers don't have to look for the Gtk Style class and so.

Thoughts?

OctoD commented 4 years ago

It would be a good idea, could you please open a PR for it? Thanks!