search

alcadica / develop

A simple tool to help elementary OS developers to develop their own apps and widgets.
https://github.com/alcadica/develop
GNU General Public License v3.0
40 stars 7 forks source link

Application should inherit from Gtk.Application #48

Closed marbetschar closed 4 years ago

marbetschar commented 4 years ago

Your App skeleton inherits from Granite.Application which I never came across before. After I checked back, the recommended way these days for applications is to inherit from Gtk.Application.

Is there a way to communicate the version of the skeletons? I'm aware there are a lot of moving parts and things change over time, so a deviation from official guidelines is inevitable - but right now I don't see a way to easily verify if the generated App skeleton does reflect the latest recommendations.

Which lets me fall back to stick the parts together manually to be safe - even though maybe just a few things changed.

Maybe we can even ask the elementary developers to introduce a version number for the Developer Documentation which you can match your skeleton versions on...?

marbetschar commented 4 years ago

Just seen you already fixed this in your source code - but my just installed version from AppCenter does not seem to contain the latest fixes....

OctoD commented 4 years ago

Hello @marbetschar, this issue will be closed since a new version is rolling out. Thanks for reporting!