jrquirk
commented
9 years ago Based on what you said and the diff, I support this merge. The GetCoarseTimeOffset thing worries me, but if it works with our current calibration DB then the merge is fine. We can make an issue out of it.
benkrikler
I'm opening this pull request so I can start a new feature to go back to the template waveform analysis stuff.
I'll try to summarize the changes that could effect others since they're in previously existing or common code:
BeginPulsesandEndPulsesmethods now return default iterators rather than throwing an exception, since it's quite possible a particular channel saw no pulses in a TME, without there being a problem in the calling code or the actual setup.TSiliconEventhas been added. This is the result of the pairing and combining of hits in the Silicon detectors. Each Silicon event is stored within the muon event that had the hits contained. A module calledMakeSiliconEventswas added as well to do the work. Perhaps that should be merged withMakeMuonEventsas an option to run with. If we don't want this approach on develop then I can remove this class from TMuonEvent.IDs::sourceas a string that is directly c++ valid. Pass in true to thestr()method and the returned string will have all bad punctuation characters replaced with underscores.GetCourseTimeOffsetmethod now removes everything but the first configuration options from the config string before looking in the calibration DB. This is slightly more robust than the previous method which allowed only a single CFT value to be given, but is still very very hacky and should definitely be improved in the future.I think that's the bulk of it. I don't want this taking too much of my time, so I'm going to leave this request up until tomorrow before I merge, unless I hear otherwise.