search

alcatraz / Alcatraz

Package manager for Xcode
alcatraz.io
MIT License
9.88k stars 1.15k forks source link

Fix a name parsing issue if the plugin name includes any '.' character #437

Closed azurechen closed 8 years ago

azurechen commented 8 years ago

If any plugin name includes "." character such like "R.swift", the installation process will be interrupt at 100%. Because the name parsing error causes loading bundle failed

azurechen commented 8 years ago

Hi, is anybody free to review this PR? I really want to fix it because my plugin can't be installed well due to this small problem. It will be very helpful for me! Thank you very much

guillaumealgis commented 8 years ago

Looks good :+1:

Thank you @azurechen

guillaumealgis commented 8 years ago

Just released Alcatraz 1.1.18 with a few bugfixes around the pbxproj parsing, including your commit. Your plugin R.swift now installs fine.

azurechen commented 8 years ago

@guillaume-algis Thank you!