Installing plugin sometimes fails

alcatraz / Alcatraz

Package manager for Xcode

alcatraz.io

MIT License

9.88k stars 1.15k forks source link

Installing plugin sometimes fails #452

Open revolter opened 8 years ago

revolter commented 8 years ago

I think that in 90% of cases, when I try to install any plugin, the loading bar increases rapidly to about 20%, then resets to 0. I the click the Install button again, and sometimes:

it works normally
it does the same thing 2 or 3 times.

guillaumealgis commented 8 years ago

That would indicate a network error while downloading the plugin.

Could you open up Console.app and paste here the errors you see there when the install fail? Thanks!

revolter commented 8 years ago

Sorry for the delay!

I think I stumbled upon another related issue, because this time, It doesn't install even after 10 retries. The Console had these printed:

23/04/16 13:48:06,989 Xcode[46645]: Updating Repo: /Users/revolt/Library/Application Support/Alcatraz/Plug-ins/Build Me Up
23/04/16 13:48:08,556 Xcode[46645]: Git fetch output: 
23/04/16 13:48:08,562 Xcode[46645]: Git reset output: HEAD is now at 224bd39 Added ability to customise output
23/04/16 13:48:08,565 Xcode[46645]: Wasn't able to find: Build Me Up.xcodeproj in /Users/revolt/Library/Application Support/Alcatraz/Plug-ins/Build Me Up

but the file exists. Is is because of the spaces in the folder's name?

guillaumealgis commented 8 years ago

@revolter the problem is that the plugins names in https://github.com/alcatraz/alcatraz-packages/blob/master/packages.json are not matching the plugin's .xcodeproj filenames. I just submitted a PR to be less strict about that, this fixes the issue.

Thanks for the report!

bob-carson commented 8 years ago

I'm having the same issue trying to download Build Time Analyzer for Swift screen shot 2016-05-06 at 11 56 02 am

guillaumealgis commented 8 years ago

Thanks for the report @carvinebob! This will be fixed too by #461. I'll ping the other maintainers to know if they have time to review it.

guillaumealgis commented 8 years ago

Appart from some plugins not building correctly, it seems the observed behavior could result from the following steps:

Alcatraz loads the plugin list;
User click on install button;
Install button starts filling up;
Screenshot for the plugin finishes being downloaded;
Alcatraz reloads the plugin's cell to update the screenshot;
The reload resets the install button to 0% fill.

I did not have time to test my assumptions more thoroughly, just dumping my thoughts for later, sorry 😐