Modify .pullapprove.yml regex

davegaeddert commented 8 years ago

Hey everybody -- don't want to butt in here but I noticed that PullApprove isn't detecting all of your 👍 's in comments. This should hopefully fix some of that.

A little while ago GitHub changed their UI so that when you type : and then pick an emoji from the autocomplete, it inserts the actual Unicode instead of just a :+1: string. We made some changes on PullApprove so that people wouldn't have to add Unicode to their yml (\U0001f44d), but the :\+1: needs to be in the regex in one piece for that to work automatically. I just changed the way your regexes were written so that that is the case.

jurre commented 8 years ago

👍

guillaumealgis commented 8 years ago

+1

jurre commented 8 years ago

Oh right, haha

+1

alcatraz / Alcatraz

Modify .pullapprove.yml regex #473