search

alcatraz / Alcatraz

Package manager for Xcode
alcatraz.io
MIT License
9.87k stars 1.15k forks source link

Verify the images we download are valid before displaying them #480

Closed guillaumealgis closed 8 years ago

guillaumealgis commented 8 years ago

This fixes the crash "Cannot lock focus on image because it is size zero". We won't attempt to display invalid images anymore.

The origin of the invalid image data is still not 100% clear though, but I suspect that the lack of error handling in ATZDownloader (the error param of the completion block is always nil) might be it.

I'll fix that in another PR when I have more time, and when we get to the root of the problem with @piv199 in https://github.com/alcatraz/Alcatraz/issues/479.

Fixes #320 #334 #335 #479.

kattrali commented 8 years ago

Simple and effective, 👍

Nice work debugging as well.

jurre commented 8 years ago

👍 lgtm

Approved with PullApprove

guillaumealgis commented 8 years ago

Thank you @kattrali and @jurre :)

Could one of you with push access to master release 1.1.19? It should just be a matter of bumping version in Alcatraz/Alcatraz-Info.plist and make shipit. Thanks!