alcatraz / alcatraz-packages

Package list repository for Alcatraz
alcatraz.io
382 stars 386 forks source link

add Refactor Code plugin #531

Closed charsdavy closed 8 years ago

charsdavy commented 8 years ago

refactor some method style, such as setter

jurre commented 8 years ago

You've added it as a file_template, it looks like this is a plugin so it should go under the plugins key in the JSON file.

charsdavy commented 8 years ago

I had added the key "Refactor Code" in the JSON file.

jurre commented 8 years ago

The JSON file is split up into 4 different parts: plugins, file_templates, color_schemes and project_templates. Make sure to add your package to the right category or it won't install.

Your plugin is listed under file_templates and it should be under plugins. It will not work this way

charsdavy commented 8 years ago

I'm so sorry. I have added the content in file_templates and plugins key.

jurre commented 8 years ago

Great, now it just needs to be removed from color_schemes

charsdavy commented 8 years ago

I had added the "Refactor Code" and its some infomation in only 'plugins' and 'file_templates' key.

jurre commented 8 years ago

Oh, they are different projects! Maybe we could give the file_templates one a different name? Like Refactor Code File Templates to make it clear they're not the same? If you'd prefer to keep them the same let me know and I'll go ahead and merge it

It looks like this file_template is in there by accident:

 +      },
 +      {
 +        "name": "Refactor Code",
 +        "url": "https://github.com/kattrali/Xcode-Plugin-Template",
 +        "description": "Project Template for creating a plugin for Xcode 5+"
charsdavy commented 8 years ago

I just want to submit plugin "Refactor Code". I can remove "Refactor Code" from 'file_templates' key?Thanks

charsdavy commented 8 years ago

I just want to submit plugin,so I remove the "Refactor Code" from file_templates, color_schemes and project_templates. And I know yours JSON file work now.Thanks very much.