search

alcatraz / alcatraz-packages

Package list repository for Alcatraz
alcatraz.io
382 stars 386 forks source link

Added my theme XCore #630

Closed MarcusJohnson91 closed 8 years ago

MarcusJohnson91 commented 8 years ago

I was wondering what the correct key was! I'll fix that asap.

Edit: My IDE didn't unfold the code, so I thought there was only the one section. I'm updating my repo.

guillaumealgis commented 8 years ago

Thanks for fixing @bumblebritches57, I would be nice if you could move the brace on a new line, and then we're good to go 👍

(didn't mean to approve the changes yet. this new UI is somewhat confusing)

MarcusJohnson91 commented 8 years ago

Alright. I'm pushing that fix rn.

MarcusJohnson91 commented 8 years ago

It's not showing up here, the other day I did re-clone it, so you'll either need to go to https://github.com/bumblebritches57/alcatraz-packages/commit/1a2c6850d181229b8aa53281d6602aa1d946981c

Or, how do I update this PR/ should I make a new PR from my current repo?

guillaumealgis commented 8 years ago

@bumblebritches57 usually you just have to push more commits on the branch you created for the PR. No need to re-clone anything.

If you want to keep the commit history clean, you can also rewrite it (with git commit --amend or git rebase) and git push -f on your branch.

See https://stackoverflow.com/questions/9790448/how-to-update-a-pull-request

Don't worry about it though, the brace is no big deal, and the JSON needs a cleanup anyway. I'll do it 👍

guillaumealgis commented 8 years ago

Thank you @bumblebritches57 !