alcatrazEscapee / Chocolate

A mod that fixes some annoying bugs with vanilla's data driven world gen in 1.16
https://www.curseforge.com/minecraft/mc-mods/chocolate-fix
MIT License
4 stars 3 forks source link

[1.16.5] Error when stopping server #8

Closed MarioSMB closed 3 years ago

MarioSMB commented 3 years ago

When stopping a server, a configuration error is shown which may cause the server to hang forever without actually stopping.

Here is the error from the log:

[31Mar2021 15:50:11.454] [Server thread/ERROR] [net.minecraftforge.fml.config.ConfigFileTypeHandler/]: Failed to remove config ./world/serverconfig/chocolate-server.toml from tracker!
java.lang.NullPointerException: null
    at com.electronwill.nightconfig.core.file.FileWatcher.removeWatch(FileWatcher.java:134) ~[core-3.6.2.jar:?]
    at net.minecraftforge.fml.config.ConfigFileTypeHandler.unload(ConfigFileTypeHandler.java:76) ~[forge:?]
    at net.minecraftforge.fml.config.ConfigTracker.closeConfig(ConfigTracker.java:114) ~[forge:?]
    at net.minecraftforge.fml.config.ConfigTracker.lambda$unloadConfigs$2(ConfigTracker.java:88) ~[forge:?]
    at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
    at java.util.Collections$SynchronizedCollection.forEach(Collections.java:2067) ~[?:?]
    at net.minecraftforge.fml.config.ConfigTracker.unloadConfigs(ConfigTracker.java:88) ~[forge:?]
    at net.minecraftforge.fml.server.ServerLifecycleHooks.handleServerStopped(ServerLifecycleHooks.java:135) ~[forge:?]
    at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:682) ~[?:?]
    at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:232) ~[?:?]
    at java.lang.Thread.run(Thread.java:834) [?:?]
MarioSMB commented 3 years ago

After some hours of debugging, I've tracked down the cause to another mod: Performant. Its config was rewritten in a recent update and it didn't handle an old config properly. Apologies for the false positive here.