Hope to fix issue with sponge

alcatrazEscapee / tinkers-forging

A Minecraft mod that adds TFC Style Forging to 1.12+

https://minecraft.curseforge.com/projects/tinkers-forging

GNU General Public License v3.0

15 stars 5 forks source link

Hope to fix issue with sponge #30

Open Caishangqi opened 5 years ago

Caishangqi commented 5 years ago

I had read the issue #22 and send to this issue to spongeforge. They said that Sponge can't do any extra transformations on mod classes, but the mod author can inadvertently support Sponge by modifying their code here to instead be written as: https://github.com/SpongePowered/SpongeForge/issues/2900#issuecomment-516636532

I ask you to fix this issue; I really like thinkers forging :) , and it is a pity that I can not add it to my server.

alcatrazEscapee commented 5 years ago

I'd like to, and if all it takes is an extra call to super then I'm all for it. However, that method was intentionally changed from just calling super, as it doesn't check the NBT share tag for syncing to the client, which is important because otherwise heat won't get synced at all.