search

alces-software / adminware

A sandbox CLI for running commands remotely across nodes
1 stars 0 forks source link

Implement the `view tool` command #123

Closed WilliamMcCumstie closed 5 years ago

WilliamMcCumstie commented 5 years ago

The view tool command acts as a front end to what is stored within the config,yaml it also prints outs the command name based on the tool's file path. Finally it works out which files will be scp based on the tool's directory.

This did require updating how additional_namespace works as it had a bug in it (see https://github.com/alces-software/adminware/commit/3b97d6318c802d88b545d9e6046a50a8052f78a3). This PR also implements a proper Config.name method that combines the tool "name" and namespaces

WilliamMcCumstie commented 5 years ago

I think the distinction between if a command is "interactive" or has to be "interactive only" is fairly moot. Technically it is the shell that determines if a command is interactive or not which means the following is perfectly possible (but unwise): top > /tmp/file

As far as the interactive flags is concerned, it should describe what happens when I run:

adminware run tool my super awesome tool

Now currently this doesn't include interactive commands, but eventually it will. The view tool command should reflect this behaviour.