search

alces-software / adminware

A sandbox CLI for running commands remotely across nodes
1 stars 0 forks source link

Additional command changes to `run tool` #136

Closed WilliamMcCumstie closed 5 years ago

WilliamMcCumstie commented 5 years ago

This PR expands on #133 and adds/fixes a few additional features:

  1. It adds the remote_arguments back into the CLI, however the command syntax has changed to: run tool TOOL NAME <--node|--group> [REMOTE_ARGUMENTS] This has required modifying the command_generation code, which isn't ideally. This code has been duplicated from another repo. See #135

  2. It sets the click_group help text again

  3. Arguments to run tool can be escaped by starting the string with: \. This allows option flags to be passed through click without erroring. See #134

DavidMarchant commented 5 years ago

Apart from the mis-diagnosed issues with arguments which will be redone in a later PR this is looks good & i'll merge it now