search

alces-software / adminware

A sandbox CLI for running commands remotely across nodes
1 stars 0 forks source link

Unnecessary verbose `view` commands #138

Closed WilliamMcCumstie closed 5 years ago

WilliamMcCumstie commented 5 years ago

Looking over the view tool and view tools commands, they have turned out almost the same:

(venv) [root@master(unconfigured) adminware]# bin/run-cli view tool
Usage: adminware view tool [OPTIONS] COMMAND [ARGS]...

  See more details about your tools

Options:
  --help  Show this message and exit.

Commands:
  namespace  List details for further tools
  top        See tool's details

(venv) [root@master(unconfigured) adminware]# bin/run-cli view tools

top -- MISSING: Help for top
Only runnable interactively

namespace -- see 'viewt tools namespace

The only difference is view tools dumps tool information along side the group info. IMO view tool looks cleaner and will be more intuitive. The same issue applies to view family and view families.

Instead the view families and view tools commands should be axed. This will directly impact #129 and will likely prevent merging it.

view family will need to be redone as a standalone command. It also needs to remove the dependency on click_tools and use the Config object to create its commands.

WilliamMcCumstie commented 5 years ago

groups can probably also be dropped as well. Then view group <group_name> commands could be added (similar to view tool). Running view group by itself will then need to list the groups. This can be done by generating a click command for each group.