search

alces-software / adminware

A sandbox CLI for running commands remotely across nodes
1 stars 0 forks source link

Various "small" tweaks to adminware #144

Closed WilliamMcCumstie closed 5 years ago

WilliamMcCumstie commented 5 years ago

Turns out the buggy parsing of arguments was due to an string being passed in instead of an array. This meant the string was joined on spaces. This fixes #134. Also click supports -- to separate arguments from options. So the \ escaping has been removed.

Also the interrupt handling has been improved. It now stops all future Jobs from running and kills the ssh connection of current Jobs. This did require building a ssh connection kill switch using python threading.Event and even more threads

DavidMarchant commented 5 years ago

Yep LGTM! I won't pretend to understand what an ssh kill-switch is!