alces-software / adminware

A sandbox CLI for running commands remotely across nodes
1 stars 0 forks source link

The `pass_context` flag does not pass the context #161

Closed WilliamMcCumstie closed 5 years ago

WilliamMcCumstie commented 5 years ago

I find it a bit confusing that the pass_context flag does not pass the context to the method: https://github.com/alces-software/adminware/blob/1b322141be099ad70e91cb2272cfe8e7a0c9882b/src/commands/run.py#L44

Either it shouldn't be there OR the context should be passed into the runner method. I understand there is an internal reason why pass_context is require BUT this should be hidden from the commands files unless they explicitly ask for it.