Feat/confirmation text - Githubissues

alces-software / adminware

A sandbox CLI for running commands remotely across nodes

1 stars 0 forks source link

Feat/confirmation text #166

Closed DavidMarchant closed 5 years ago

DavidMarchant commented 5 years ago

Fixes #102 Will probably conflict with both https://github.com/alces-software/adminware/pull/162 and https://github.com/alces-software/adminware/tree/dev/status

WilliamMcCumstie commented 5 years ago

This branch needs to be rebased on develop due to the changes to create_command

DavidMarchant commented 5 years ago

Rebased on new develop for changes in create_command and the hash__node__group dict

DavidMarchant commented 5 years ago

All changes now made in the above The result looks like this:


You are about to run:                                                              
nspace1 nspace2 cmd4                                                               
nspace1 nspace2 cmd5                                                               
nspace1 nspace2 nspace3 cmd6                                                       
nspace1 nspace2 nspace4 cmd7                                                       
nspace1 nspace2 cmd12                                                              
Over nodes: node, node[2-4, 6-7]                                                   
Please enter [y/n] or 'more' for more info:```

DavidMarchant commented 5 years ago

Ah as it stands N isn't default, do you want it to be?

Either way done here: https://github.com/alces-software/adminware/pull/166/commits/b9777132bc23047ed71627443ef618417a98c655