search

alces-software / adminware

A sandbox CLI for running commands remotely across nodes
1 stars 0 forks source link

Remove paramiko requirement #97

Closed DavidMarchant closed 6 years ago

DavidMarchant commented 6 years ago

It's only use was an import that was never referenced again (also removed) A version (>=2.4) is required by fabric but this should be fine Setup seems to be fine with new requirements but please tell me if i've broken anything, not at all impossible

WilliamMcCumstie commented 6 years ago

However plumbum should probably be removed

DavidMarchant commented 6 years ago

Ok I've reinstated the paramiko one, I think i misunderstood the purpose of the requirements file (specifying versions rather than specifying actually which packages are needed) However are you sure about removing plumbum? It's explicitly required & used here https://github.com/alces-software/adminware/blob/fix/paramiko-dependency/src/groups.py#L5

WilliamMcCumstie commented 6 years ago

Ahh right, plumbum is still used for the nodeattr stuff. It was originally being used to preform the ssh as well. This LGTM then