With build_method: uefi (note: also tried build_method: uefikickstart and build_method: uefi-kickstart) it isn't rendering the files that it should be, what is expected is that the file in the repo uefi-kickstart/default is rendered to /var/lib/tftpboot/efi/grub.cfg-MACADDRESS (MACADDRESS being the value that is used in the standard build method for /var/lib/tftpboot/pxelinux.cfg/MACADDRESS). This was in the initial requirements for UEFI support in #164
Further to the above, uefi-kickstart isn't really an appropriate name for the directory as kickstart refers to the centos installation file which is separate to the boot method (pxe/uefi). I'd suggest it would be clearer for the directory in the repo to be called simply uefi (much like how the pxelinux directory is named just that). It seems like the naming convention changed during #176 from using the repo directory uefi to uefi-kickstart. (@ste78 it seems like you indicated that this build method should be called uefi-kickstart but I'd argue that if we're calling it that then pxelinux should become pxelinux-kickstart to keep these in line with bootmethod-installmethod naming convention - plus, the build method didn't even end up being called uefi-kickstart but the repo directory did!)
One final thing (which I'm just noting here as part of the brain dump) is that the UEFI boot file isn't up to date with some of the amendments made to pxelinux which setup things like console redirection and remote syslog.
The actions for this issue being:
Fix the issue with /var/lib/tftpboot/efi/grub.cfg-MACADDRESS not being rendered or put in place
Refactor both metalware and metalware-default repo to use uefi instead of uefi-kickstart for the grub file
Update uefi/default in metalware-default to include additional functionality (SF to do this)
While the refactoring/consistency changes would be nice they're not critical so if we could just get the file rendering issue fixed then that'd be ideal.
With
build_method: uefi
(note: also triedbuild_method: uefikickstart
andbuild_method: uefi-kickstart
) it isn't rendering the files that it should be, what is expected is that the file in the repouefi-kickstart/default
is rendered to/var/lib/tftpboot/efi/grub.cfg-MACADDRESS
(MACADDRESS
being the value that is used in the standard build method for/var/lib/tftpboot/pxelinux.cfg/MACADDRESS
). This was in the initial requirements for UEFI support in #164Further to the above,
uefi-kickstart
isn't really an appropriate name for the directory as kickstart refers to the centos installation file which is separate to the boot method (pxe/uefi). I'd suggest it would be clearer for the directory in the repo to be called simplyuefi
(much like how thepxelinux
directory is named just that). It seems like the naming convention changed during #176 from using the repo directoryuefi
touefi-kickstart
. (@ste78 it seems like you indicated that this build method should be calleduefi-kickstart
but I'd argue that if we're calling it that thenpxelinux
should becomepxelinux-kickstart
to keep these in line withbootmethod-installmethod
naming convention - plus, the build method didn't even end up being calleduefi-kickstart
but the repo directory did!)One final thing (which I'm just noting here as part of the brain dump) is that the UEFI boot file isn't up to date with some of the amendments made to pxelinux which setup things like console redirection and remote syslog.
The actions for this issue being:
/var/lib/tftpboot/efi/grub.cfg-MACADDRESS
not being rendered or put in placemetalware
andmetalware-default
repo to useuefi
instead ofuefi-kickstart
for the grub fileuefi/default
inmetalware-default
to include additional functionality (SF to do this)